Use docker to generate the new-pyffi code for installation/make zip#562
Draft
TagnumElite wants to merge 4 commits intoniftools:developfrom
Draft
Use docker to generate the new-pyffi code for installation/make zip#562TagnumElite wants to merge 4 commits intoniftools:developfrom
TagnumElite wants to merge 4 commits intoniftools:developfrom
Conversation
Also, fail the makezip script when docker fails Also Also, Only copy the formats we need because it saves some space
Member
|
Is this still a draft pull request or do you think it's functional? |
Member
Author
|
It works on my machine, the only reason I am not happy with it is it seems to be too niche for me. To use this only for making the zip files feels like it is doing too little. I wanted to improve this so that the generated files could be used in an IDE but I haven't had any free time lately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@niftools/blender-niftools-addon-reviewer
Overview
This pull request uses docker to use cobra-tools and new-pyffi to generate the code required by the blender addon to be functional.
Manual
Simply run
install/makezip.(bat|sh)to testAdditional Information
You will require docker to run these