Fix "Index too big"-messages when toggling filtered-view modes#223
Open
gin-ahirsch wants to merge 3 commits intonickbnf:masterfrom
Open
Fix "Index too big"-messages when toggling filtered-view modes#223gin-ahirsch wants to merge 3 commits intonickbnf:masterfrom
gin-ahirsch wants to merge 3 commits intonickbnf:masterfrom
Conversation
The function returns an index, but returned the line-number instead. If there is no lower-bound we return 0, since the first element is already greater (if we have any).
danberindei
pushed a commit
to danberindei/glogg
that referenced
this pull request
Apr 21, 2021
danberindei
pushed a commit
to danberindei/glogg
that referenced
this pull request
Apr 21, 2021
danberindei
pushed a commit
to danberindei/glogg
that referenced
this pull request
Apr 21, 2021
This reverts commit c10b30e.
danberindei
pushed a commit
to danberindei/glogg
that referenced
this pull request
Apr 21, 2021
This reverts commit 49f67f9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got "Index too big in LogFilteredData" warnings when switching between the filtered-view modes (marks/matches).
These changes should prevent the situation from occurring.