Updated VIPB to install AF core menus to their correct locations.

[niACS]

GitHub Issue for the Pull Request

(#155)

GitHub Discussions Related to this Pull Request

None

Checklists

Completing these checklists ensures that your PR meets our build server requirements on the first attempt. If you're unable to complete any of the following checks, please submit your PR as a draft to the best of your ability. We will provide any clarification you may need after posting it.

• [x ] I do not require assistance from NI to complete any of the following checks.
• [x ] The changes in this PR are based on the appropriate NI-repo feature branch
• [x ] I am submitting the changes in this PR to the appropriate NI-repo feature branch
• I built a VI Package using the Powershell build tool.
• [x ] I installed the VI Package produced by the Powershell build tool and tested my change.
• [x ] I tested my changes after installing the VI package.
• [x ] NI has my contributor license agreement.

I did not use the Powershell tool. As the bug calls for updating the VIPB, I built and tested the VIP by hand.

Summary of Changes

The AF Core messages were updated in PR 154. I have added those menus to the VI Package build specification, so they will be installed to the correct location.

Reason for Change

Menus weren't being installed to the correct location.

Testing

I installed the package and visually confirmed that the palettes were correct.

[shivaprasad-basavaraj]

I tested the change and while the change itself looks fine to me, I wasn't sure why we have two VIPB files in the Core folder (Core/Actor Framework 2024 for 2020.vipb and Core/Actor Framework.vipb) and if both should be updated. It looks like we have been submitting only the 2024 for 2020 built vip file into the Builds folder.

@niACS looks ike you were the creator for both of these VIPB files. Could you let me know why we have two of these and if both should be updated? If one of these is obsolete we should probably delete it from the repo.

[niACS]

@shivaprasad-basavaraj Good catch; it looks like a mistake on my part. I'll correct it today or tomorrow.

[niACS]

@shivaprasad-basavaraj I have removed Core/Actor Framework.vipb. It was an old and horribly wrong version. I have pushed the change; do I need to do anything else?

[shivaprasad-basavaraj]

@shivaprasad-basavaraj I have removed Core/Actor Framework.vipb. It was an old and horribly wrong version. I have pushed the change; do I need to do anything else?

@niACS This looks good to me. I will merge the PR. On a side note I was wondering if having the suffix 2024 for 2020 makes sense any more. Presumably this was done initially since we had taken the Actor Framework that shipped with LV 24 and built the VIP with LV 2020 so that LV 2020 or later can use it. Since the repo itself is in active development and we would keep adding new features its no longer the AF that shipped with LV 24. It may get confusing to the end user who might think this has changes only from LV 24.

So in my opinion we should just drop the 2024 for 2020 suffix. We can continue to target LV 2020 and later like before or re-evaluate a version if we start using newer features from LabVIEW.

@niACS Let me know if you agree.