Move "Root Actor is Loaded.vi" to AFPP Shared Library#122
Move "Root Actor is Loaded.vi" to AFPP Shared Library#122neilfenstein wants to merge 24 commits intoni:feature/50-move-root-actor-class-is-loadedvi-to-afpp-sharedlvlibfrom
Conversation
…ation. Deleted deprecated package builds (builds 12 and 17). Added build 18.
Resolves issue 31, 32, and 33.
…messages-pallete Resolved issue ni#28
…ared Lib Relocated on disk Update the icon to show AFPP Header
|
@neilfenstein can you please sign your commits? This is a blog post from SAS Workshops that explains how to do that. |
… develop # Conflicts: # Builds/actor_framework_2024_for_2020-2.0.0.18.vip # Core/Actor Framework 2024 for 2020.vipb
# Conflicts: # Documentation/Manual Test Scripts/Manual Test Script for Actor Framework Project Providers.docx
|
I had to update my code with an alias file change and the .tgitignore file to get a sign commit, let me know if this is OK, if not I can re-fork and commit the changes signed. |
|
i haven't lost track of this @neilfenstein . AF has foundational CI only and no release pipeline, i am planning on introducing it very soon. |
…or-to-the-open-source-repository Feature/49 add state pattern actor to the open source repository
Revert "Merge pull request ni#140 from niACS/feature/49-add-state-patte…
|
@neilfenstein Did you run the manual test plan for the providers, here: https://github.com/ni/actor-framework/blob/develop/Documentation/Manual%20Test%20Scripts/Manual%20Test%20Script%20for%20Actor%20Framework%20Project%20Providers.docx |
niACS
left a comment
There was a problem hiding this comment.
I have manually inspected the provider libraries to confirm these changes, and I have run the manual test script for the providers.
All work was performed in LabVIEW 2020 20.0.1f1.
GitHub Issue for the Pull Request
Issue 50
GitHub Discussions Related to this Pull Request
List any GitHub discussion links related to this PR
Checklists
Completing these checklists ensures that your PR meets our build server requirements on the first attempt. If you're unable to complete any of the following checks, please submit your PR as a draft to the best of your ability. We will provide any clarification you may need after posting it.
Summary of Changes
Moved Root Actor is Loaded.vi from Message Maker Library to AFPP Shared Library.
Reason for Change
Reduction of Library linkage.
Visual Aids
Dependency linkage before work




Dependency linkage after work
Updated Icon and Library Namespace visual
Location in AFPP Shared Library
Additional Information
Include any further details that may assist the reviewer in understanding the context of this PR.
Testing
This section describes the automated and manual tests performed for this bugfix/feature.
Manual Tests
Created new project and added the vi before moved and repeated after moved as shown in the screen shots above.