[simplejson,ultrajson] Implement formatters for simplejson and ultrajson (ujson)#64
Open
[simplejson,ultrajson] Implement formatters for simplejson and ultrajson (ujson)#64
Conversation
This reverts commit 5f13ff6. The bug is only on pypy + mac runner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per title
Note that both libraries have different handling of
datetime.datetimeandbytesobjects. In the case ofbytesthey will error if they receive any non-printable characters. I've not yet been able to determine if there is a work around to the encoding or if it is just the decoding when testing that is the problem.Test Plan