Make sure nginx.org repos are used in alpine-slim#1029
Merged
thresheek merged 2 commits intonginx:masterfrom Mar 2, 2026
Merged
Make sure nginx.org repos are used in alpine-slim#1029thresheek merged 2 commits intonginx:masterfrom
thresheek merged 2 commits intonginx:masterfrom
Conversation
Currently, Alpine upstream repos ship the same version/release of nginx as we do, which means apk prefers it over ours. We make sure that the correct version is chosen by redefining what repositories apk has at the invocation, but that means we need to preinstall the dependencies, so let's do just that.
thresheek
changed the title
Member
Author
|
I decided not to implement the same logic for the images based on the slim since modules have a |
Member
Author
|
... And it fixes the issue spotted by CI in https://github.com/nginx/docker-nginx/actions/runs/22485098447/job/65216474252 - good thing we have tests! (and good thing Alpine's defaults arent the same as ours) |
This was referenced Feb 28, 2026
oxpa
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently, Alpine upstream repos ship the same version/release of nginx
as we do, which means apk prefers it over ours.
We make sure that the correct version is chosen by redefining what
repositories apk has at the invocation, but that means we need to
preinstall the dependencies, so let's do just that.