Add permitted keys for ext map and rational#3993
Merged
mahesh-panchal merged 2 commits intonf-core:mainfrom Mar 12, 2026
Merged
Add permitted keys for ext map and rational#3993mahesh-panchal merged 2 commits intonf-core:mainfrom
mahesh-panchal merged 2 commits intonf-core:mainfrom
Conversation
✅ Deploy Preview for nf-core-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nf-core-main-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
@nf-core-bot fix linting |
mashehu
approved these changes
Mar 11, 2026
Contributor
mashehu
left a comment
mashehu
left a comment
There was a problem hiding this comment.
could you also make a PR against the docs-v2 branch with these changes please
Member
Author
|
A separate PR or change where this one is going to? |
Member
Author
|
Or rebase against the |
Contributor
|
A separate PR, so we have it in the current version as well as in v2 |
Contributor
|
can you write an issue on tools so we lint for this? Or is there another way we can quickly validate this? |
Member
Author
|
At the moment I'm using a bash command: But I'll make an issue on linting too (I'm surprised there isn't one). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds which keys are permitted in the
extmap, and the rational behind using theextmap.Closes #3412
@netlify /docs/contributing/components/ext_args