docs :add advisory example image#3976
Closed
beumjin wants to merge 2 commits intonf-core:docs-v2from
Closed
Conversation
✅ Deploy Preview for nf-core-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mashehu
requested changes
Mar 11, 2026
| They prioritise clarity and practical value, helping users avoid common pitfalls. | ||
|
|
||
| <!-- TODO: Add image of advisory somewhere on this page --> | ||
|  |
Contributor
There was a problem hiding this comment.
this is just the nf-core logo, not a screenshot of an advisory
mashehu
reviewed
Mar 11, 2026
Contributor
There was a problem hiding this comment.
this is quite wide screen format screenshot, can you maybe make the window a bit smaller when you make the screenshot?
Contributor
There was a problem hiding this comment.
and images should go to sites/docs/src/assets/images instead of public, so Astro optimizes them
Member
|
This has some scary conflicts due to the accidently committed @PeterTSmith1997 will make a fresh PR to wrap this up, and we can tag @beumjin to ensure they get credit :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an advisory example image to replace the TODO comment. #10
@netlify /docs/community/advisories