Skip to content

XIOS: Throw an error for non-positive read or write periods#1070

Open
joewallwork wants to merge 4 commits intodevelopfrom
issue971_zero-restart-period
Open

XIOS: Throw an error for non-positive read or write periods#1070
joewallwork wants to merge 4 commits intodevelopfrom
issue971_zero-restart-period

Conversation

@joewallwork
Copy link
Copy Markdown
Contributor

@joewallwork joewallwork commented Mar 26, 2026

XIOS: Throw an error for non-positive read or write periods

Fixes #971

Task List

  • Linked an issue above that captures the requirements of this PR
  • Defined the tests that specify a complete and functioning change
  • Implemented the source code change that satisfies the tests
  • Commented all code so that it can be understood without additional context
  • No new warnings are generated or they are mentioned below
  • The documentation has been updated (or an issue has been created to do so)
  • Relevant labels (e.g., enhancement, bug) have been applied to this PR
  • This change conforms to the conventions described in the README

Change Description

I tried out XIOS with zero restart period and it stalled so figured we should throw a warning to stop users encountering this.

I also noticed that 0 is handled in a special way, implying that the period is the full length of the simulation.

As such, I've made it so that 0 gets handled in this way consistently and anything negative throws an error.


Test Description

n/a


Documentation Impact

The XIOS docs page has been updated to reflect this.

@joewallwork joewallwork self-assigned this Mar 26, 2026
@joewallwork joewallwork added enhancement New feature or request ICCS Tasks or reviews for the ICCS team labels Mar 26, 2026
@joewallwork joewallwork changed the title XIOS: Throw an error for zero restart period XIOS: Throw an error for non-positive read or write periods Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ICCS Tasks or reviews for the ICCS team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check runLength=0 works with XIOS

1 participant