XIOS: Throw an error for non-positive read or write periods#1070
Open
joewallwork wants to merge 4 commits intodevelopfrom
Open
XIOS: Throw an error for non-positive read or write periods#1070joewallwork wants to merge 4 commits intodevelopfrom
joewallwork wants to merge 4 commits intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XIOS: Throw an error for non-positive read or write periods
Fixes #971
Task List
Change Description
I tried out XIOS with zero restart period and it stalled so figured we should throw a warning to stop users encountering this.
I also noticed that
0is handled in a special way, implying that the period is the full length of the simulation.As such, I've made it so that 0 gets handled in this way consistently and anything negative throws an error.
Test Description
n/a
Documentation Impact
The XIOS docs page has been updated to reflect this.