Skip to content

XIOS: Account for U and V fields#1068

Open
joewallwork wants to merge 9 commits intoissue1056_drop-xios-output-sectionfrom
issue1066_xios-uv
Open

XIOS: Account for U and V fields#1068
joewallwork wants to merge 9 commits intoissue1056_drop-xios-output-sectionfrom
issue1066_xios-uv

Conversation

@joewallwork
Copy link
Copy Markdown
Contributor

@joewallwork joewallwork commented Mar 19, 2026

XIOS: Account for U and V fields

Fixes #1066
Merges into #1063

Task List

  • Linked an issue above that captures the requirements of this PR
  • Defined the tests that specify a complete and functioning change
  • Implemented the source code change that satisfies the tests
  • Commented all code so that it can be understood without additional context
  • No new warnings are generated or they are mentioned below
  • The documentation has been updated (or an issue has been created to do so)
  • Relevant labels (e.g., enhancement, bug) have been applied to this PR
  • This change conforms to the conventions described in the README

Change Description

The u and v fields are not properly handled in #1063 because they use special field types ModelArray::Type::U and ModelArray::Type::V, which aren't used by any other fields. Currently, these are duplicates of ``ModelArray::Type::H`, although this might not always be the case.

In this PR, these field types are handled in the XIOS I/O implementation. An assumption is made that ModelArray::Type::U and ModelArray::Type::V are consistent with ModelArray::Type::H, but NOTEs are included to indicate where this is relevant.

I also made use of using Type == ModelArray::Type; to make things a bit easier to read.


Test Description

No changes to the tests were required.


Documentation Impact

The XIOS documentation page has been updated to mention UField and VField. I also noticed that the domain names needed updating in the same section.

@joewallwork joewallwork self-assigned this Mar 19, 2026
@joewallwork joewallwork added enhancement New feature or request ICCS Tasks or reviews for the ICCS team labels Mar 19, 2026
@joewallwork joewallwork marked this pull request as ready for review March 19, 2026 16:22
@joewallwork joewallwork mentioned this pull request Mar 19, 2026
8 tasks
@joewallwork joewallwork linked an issue Mar 19, 2026 that may be closed by this pull request
@joewallwork joewallwork requested a review from TomMelt March 26, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ICCS Tasks or reviews for the ICCS team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XIOS: Account for u and v fields

1 participant