XIOS: Account for U and V fields#1068
Open
joewallwork wants to merge 9 commits intoissue1056_drop-xios-output-sectionfrom
Open
XIOS: Account for U and V fields#1068joewallwork wants to merge 9 commits intoissue1056_drop-xios-output-sectionfrom
U and V fields#1068joewallwork wants to merge 9 commits intoissue1056_drop-xios-output-sectionfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XIOS: Account for
UandVfieldsFixes #1066
Merges into #1063
Task List
Change Description
The
uandvfields are not properly handled in #1063 because they use special field typesModelArray::Type::UandModelArray::Type::V, which aren't used by any other fields. Currently, these are duplicates of ``ModelArray::Type::H`, although this might not always be the case.In this PR, these field types are handled in the XIOS I/O implementation. An assumption is made that
ModelArray::Type::UandModelArray::Type::Vare consistent withModelArray::Type::H, butNOTEs are included to indicate where this is relevant.I also made use of
using Type == ModelArray::Type;to make things a bit easier to read.Test Description
No changes to the tests were required.
Documentation Impact
The XIOS documentation page has been updated to mention
UFieldandVField. I also noticed that the domain names needed updating in the same section.