Draft
Conversation
joewallwork
requested changes
Mar 5, 2026
Contributor
joewallwork
left a comment
joewallwork
left a comment
There was a problem hiding this comment.
It looks like this PR isn't ready yet but I noticed you requested my review so here's some early feedback.
| /docs/latex/ | ||
| /docs/xml/ | ||
| /docs/_build/ | ||
| /.venv |
Contributor
There was a problem hiding this comment.
Note that it's not considered good practice to create virtual environments called venv or .venv.
Contributor
There was a problem hiding this comment.
This script should live in the scripts directory and should include details concerning the system it's intended to be run on.
Contributor
There was a problem hiding this comment.
Again, this script should live in the scripts directory and should include sufficient information in comments to know what it does and how to use it.
…ranks and 1 2 4 8 OMP_NUM_THREADS
TomMelt
force-pushed
the
halo-dynamics
branch
2 times, most recently
from
a951eb5 to
c31114b
Compare
TomMelt
force-pushed
the
halo-dynamics
branch
2 times, most recently
from
29eefc9 to
fb6ad47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create bash scripts for profiling june_23 config
Fixes #1058
Task List
OMP_NUM_THREAD(1, 2, 4, 8) using for loopMPIprocessesbenchmark_scriptfromlaunch_scriptChange Description
Test Description
Documentation Impact
Other Details