Skip to content

Cosmetic changes#81

Merged
TomMelt merged 3 commits intofix-corner-startsfrom
cosmetic-changes
Feb 10, 2026
Merged

Cosmetic changes#81
TomMelt merged 3 commits intofix-corner-startsfrom
cosmetic-changes

Conversation

@TomMelt
Copy link
Copy Markdown
Contributor

@TomMelt TomMelt commented Feb 9, 2026

Cosmetic changes

fixes #80

Note

This PR is only cosmetic. No functionality was intentionally changed. All the tests continue to pass.

Summary

  • Renamed variables from snake_case to camelCase for consistency with C++ naming conventions
  • Updated function names and parameters throughout the codebase
  • Ensured all references to renamed variables are updated

The following cosmetic changes have been made to domain_decomp

  • Uniform(ize)d the variable names and naming conventions.
  • rename haloBufferPositions to haloEdgeBufferPositions
  • change vertex to corner
  • use CamelCase instead of underscores to bring in-line with nextsim

Renamed variables, functions, methods etc.

  • get_width()getWidth()
  • get_height()getHeight()
  • domain_overlap()domainOverlap()
  • global_extglobalExt
  • local_extlocalExt
  • total_num_procstotalNumProcs
  • num_procsnumProcs
  • is_neighbour()isNeighbour()
  • is_corner_neighbour()isCornerNeighbour()
  • send_possendPos
  • recv_posrecvPos
  • get_bounding_box()getBoundingBox()
  • get_neighbour_info()getNeighbourInfo()
  • get_neighbour_info_periodic()getNeighbourInfoPeriodic()
  • save_mask()saveMask()
  • save_metadata()saveMetadata()
  • global_0global0
  • global_1global1
  • local_ext_0localExt0
  • local_ext_1localExt1
  • halo_sizeshaloSizes
  • halo_sendhaloSend
  • halo_recvhaloRecv
  • corner_idscornerIds
  • corner_sendcornerSend
  • num_corner_neighboursnumCornerNeighbours
  • corner_send_poscornerSendPos
  • global_ext_newglobalExtNew
  • local_ext_newlocalExtNew
  • proc_idprocId
  • global_extent_namesglobalExtentNames
  • corner_neighbourscornerNeighbours
  • corner_send_pos_pcornerSendPos_p
  • corner_neighbours_pcornerNeighbours_p
  • send_pos_psendPos_p
  • recv_pos_precvPos_p

@TomMelt TomMelt self-assigned this Feb 9, 2026
@TomMelt TomMelt added the ICCS label Feb 9, 2026
@TomMelt TomMelt changed the base branch from main to fix-corner-starts February 9, 2026 18:30
@TomMelt TomMelt marked this pull request as ready for review February 10, 2026 11:30
Copy link
Copy Markdown
Contributor

@joewallwork joewallwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through and changing all these @TomMelt.

I assume we are going to stick with repo name domain_decomp rather than domainDecomp 😅

@TomMelt
Copy link
Copy Markdown
Contributor Author

TomMelt commented Feb 10, 2026

Thanks for going through and changing all these @TomMelt.

I assume we are going to stick with repo name domain_decomp rather than domainDecomp 😅

hahaha I hadn't thought of that 😅 ... but yes.

@TomMelt TomMelt merged commit 5cec6c0 into fix-corner-starts Feb 10, 2026
@TomMelt TomMelt deleted the cosmetic-changes branch February 10, 2026 20:05
This was referenced Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cosmetic changes to domain_decomp

2 participants