Merged
Conversation
cc363df to
1f65ee5
Compare
1f65ee5 to
8b02747
Compare
joewallwork
approved these changes
Feb 10, 2026
Contributor
joewallwork
left a comment
There was a problem hiding this comment.
Thanks for going through and changing all these @TomMelt.
I assume we are going to stick with repo name domain_decomp rather than domainDecomp 😅
Contributor
Author
hahaha I hadn't thought of that 😅 ... but yes. |
This was referenced Feb 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosmetic changes
fixes #80
Note
This PR is only cosmetic. No functionality was intentionally changed. All the tests continue to pass.
Summary
The following cosmetic changes have been made to
domain_decomphaloBufferPositionstohaloEdgeBufferPositionsvertextocornerRenamed variables, functions, methods etc.
get_width()→getWidth()get_height()→getHeight()domain_overlap()→domainOverlap()global_ext→globalExtlocal_ext→localExttotal_num_procs→totalNumProcsnum_procs→numProcsis_neighbour()→isNeighbour()is_corner_neighbour()→isCornerNeighbour()send_pos→sendPosrecv_pos→recvPosget_bounding_box()→getBoundingBox()get_neighbour_info()→getNeighbourInfo()get_neighbour_info_periodic()→getNeighbourInfoPeriodic()save_mask()→saveMask()save_metadata()→saveMetadata()global_0→global0global_1→global1local_ext_0→localExt0local_ext_1→localExt1halo_sizes→haloSizeshalo_send→haloSendhalo_recv→haloRecvcorner_ids→cornerIdscorner_send→cornerSendnum_corner_neighbours→numCornerNeighbourscorner_send_pos→cornerSendPosglobal_ext_new→globalExtNewlocal_ext_new→localExtNewproc_id→procIdglobal_extent_names→globalExtentNamescorner_neighbours→cornerNeighbourscorner_send_pos_p→cornerSendPos_pcorner_neighbours_p→cornerNeighbours_psend_pos_p→sendPos_precv_pos_p→recvPos_p