fix: Prevent re-joining room when leaving chat#2401
Merged
SystemKeeper merged 2 commits intomainfrom Mar 2, 2026
Merged
Conversation
Collaborator
|
I guess we can't just reuse the |
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Ivansss
force-pushed
the
fix/noid/prevent-rejoining-room-when-leaving-chat
branch
from
9ba6ee5 to
1fd3cce
Compare
Member
Author
|
/backport to stable23 please |
SystemKeeper
approved these changes
Mar 2, 2026
Collaborator
SystemKeeper
left a comment
SystemKeeper
left a comment
There was a problem hiding this comment.
Thanks for adding the test 💛
SystemKeeper
deleted the
fix/noid/prevent-rejoining-room-when-leaving-chat
branch
Collaborator
|
/backport to stable23 please |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Without this PR:
User will rejoin the conversation after leaving it, because the chat view will rejoin the conversation (in
viewWillAppear()) while moving to conversations list.With this PR:
Prevents any action on chat view's
viewWillAppear()ifleaveChat()has been called.