Skip to content

fix(talk): preset signaling mode for Talk v23.0.2+, remove unused initial state #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShGKme wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −19
Open

fix(talk): preset signaling mode for Talk v23.0.2+, remove unused initial state #1689

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09548d4
refactor(talk): remove unused initial state
ShGKme Apr 18, 2026
c98ee5e
fix(talk): preset signaling mode for Talk v23.0.2+
ShGKme Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 4 additions & 19 deletions src/shared/setupWebPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,28 +137,13 @@ function getInitialStateFromCapabilities(capabilities, userMetadata) {
}).reduce((acc, { app, key, value }) => ((acc[app] ??= {})[key] = value, acc), {})
*/

// TODO: make sure all use initial state is covered and there is no MISSED values
// TODO: when possible, migrate Initial State to capabilities
// TODO: make sure all used initial state is covered and there is no MISSED values
return {
spreed: {
call_enabled: capabilities?.spreed?.config?.call?.enabled,
signaling_mode: 'external', // MISSED
sip_dialin_info: '', // MISSED
grid_videos_limit: 19, // MISSED
grid_videos_limit_enforced: false, // MISSED
federation_enabled: capabilities?.spreed?.config?.federation?.enabled,
// default_permissions - MISSED (!)
start_conversations: capabilities?.spreed?.config?.conversations?.['can-create'],
circles_enabled: capabilities?.circles !== undefined,
guests_accounts_enabled: true, // MISSED
read_status_privacy: capabilities?.spreed?.config?.chat?.['read-privacy'],
typing_privacy: capabilities?.spreed?.config?.chat?.['typing-privacy'],
play_sounds: true, // MISSED
force_enable_blur_filter: 'yes', // Unused
// Capability added in Talk v23.0.2
// TODO: use signaling settings as the fallback for older servers
signaling_mode: capabilities?.spreed?.config?.signaling?.mode ?? 'external',
user_group_ids: userMetadata?.groups,
attachment_folder: capabilities?.spreed?.config?.attachments?.folder,
attachment_folder_free_space: userMetadata?.quota?.free ?? 0,
enable_matterbridge: false, // MISSED
},
core: {
// reference-provider-list - MISSED
Expand Down
Loading