Conversation
…rger in normal view makes it overflow in narrow screens Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
|
cc @marcoambrosini @jancborchardt your requested design change is resolved |
|
Hmm now the outer border including the close button is hidden at some points, any way to prevent that? |
jancborchardt
left a comment
There was a problem hiding this comment.
Nice!
One thing: Could we use the full height on mobile sizes? It seems odd that there’s a row on the top of unused space, instead of the modal expanding to fill the screen.
|
@janepie We artificially change the style the NcModal component so this has some side effects that are tricky to deal with. I think it's fine like it is now. @jancborchardt That's something to ask in https://github.com/nextcloud-libraries/nextcloud-vue because it would make sense to have it changed in all the NcModals (i mean, in the NcModal component itself), not just this one in assistant. Right? I just fixed a bug that only affects this assistant modal and was introduced in this repo. |
closes #418
Because of the trick we use to make the modal larger than possible with the component
sizeprop, it did not behave well on narrow screens. This is setting a max width to 100% which does the job.Thank you @evrim for reporting this and suggesting a fix (on which we agree 😁).
cc @DaphneMuller
Before
Kooha-2026-03-18-14-48-01.webm
After
Kooha-2026-03-18-14-46-16.webm
Unrelated change: Update npm pkgs.