Skip to content

fix(session-mixing): capabilities npe#16452

Merged
alperozturk96 merged 2 commits intomasterfrom
fix/session-mix-oc-capability-npe
Mar 26, 2026
Merged

fix(session-mixing): capabilities npe#16452
alperozturk96 merged 2 commits intomasterfrom
fix/session-mix-oc-capability-npe

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 commented Feb 5, 2026 •
edited by joshtrichards
Loading

  • Tests written, or not not needed

Fixes #16451

Fixes #14653

Changes

Makes OCCapability non-nullable
Checks and logs existince of it

@alperozturk96 alperozturk96 linked an issue Feb 5, 2026 that may be closed by this pull request
NPE on OCCapability.getAssistant() #16451
Closed
4 tasks
@alperozturk96 alperozturk96 force-pushed the fix/session-mix-oc-capability-npe branch from 0b7648d to 3ca50ec Compare February 9, 2026 11:28
@nextcloud nextcloud deleted a comment from github-actions Bot Feb 9, 2026
@alperozturk96 alperozturk96 linked an issue Feb 9, 2026 that may be closed by this pull request
start Nextcloud on Android 12 => Crash #16458
Closed
4 tasks
@alperozturk96 alperozturk96 mentioned this pull request Feb 9, 2026
Closed
4 tasks
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 9, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16452.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

AndyScherzinger
AndyScherzinger approved these changes Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@tobiasKaminsky
Copy link
Copy Markdown
Member

tobiasKaminsky commented Feb 10, 2026

I think this is the wrong idea to fix it:
When app is working in normal state, then it must have user and capability.
If for some reason, one of them is not available, then we need to fix it there (or prevent a call to it).

But neither user nor capability are optional and must always exist (same like e.g. server url, etc).

tobiasKaminsky
tobiasKaminsky requested changes Feb 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See last comment

@ZetaTom ZetaTom removed their request for review March 14, 2026 19:19
@alperozturk96
fix(session-mixing): capabilities npe
9dcefff 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/src/main/java/com/nextcloud/ui/composeActivity/ComposeActivity.kt
#	app/src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java
#	app/src/main/java/com/owncloud/android/ui/fragment/OCFileListBottomSheetDialog.kt
@alperozturk96
add missing places
e609e0b 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/session-mix-oc-capability-npe branch from 3ca50ec to e609e0b Compare March 26, 2026 10:29
@alperozturk96 alperozturk96 added this to the Nextcloud App 33.1.0 milestone Mar 26, 2026
@alperozturk96 alperozturk96 merged commit 157192e into master Mar 26, 2026
14 of 18 checks passed
@alperozturk96 alperozturk96 deleted the fix/session-mix-oc-capability-npe branch March 26, 2026 10:29
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 26, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice3939
Correctness7470
Dodgy code236236
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4342
Security1817
Total454448

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 26, 2026

APK file: https://github.com/nextcloud/android/actions/runs/23589559163/artifacts/6120955455
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 26, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 33.1.0

3 participants

@alperozturk96 @tobiasKaminsky @AndyScherzinger