Skip to content

Add functions to get 3D krypton maps#948

Open
mcidlaso wants to merge 190 commits into
next-exp:masterfrom
mcidlaso:ICAROS_3D
Open

Add functions to get 3D krypton maps#948
mcidlaso wants to merge 190 commits into
next-exp:masterfrom
mcidlaso:ICAROS_3D

Conversation

@mcidlaso
Copy link
Copy Markdown

@mcidlaso mcidlaso commented Dec 19, 2025 •
edited
Loading

These scripts contain functions to:

  • Make cuts on the outputs from sophronia to get the selected events and the efficiencies of the cuts
  • Get the lifetime and drift velocity for each run
  • Compute 3D krypton maps and apply them to correct the data
  • Some tests for these functions (still have a lot of work to do)

gonzaponte
gonzaponte requested changes Dec 22, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gonzaponte gonzaponte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round

Comment thread invisible_cities/icaros/correction_functions.py Outdated
Comment thread invisible_cities/icaros/correction_functions.py Outdated
Comment thread invisible_cities/icaros/correction_functions_test.py Outdated
Comment thread invisible_cities/icaros/krmap_functions.py Outdated
Comment thread invisible_cities/icaros/krmap_functions.py Outdated
Comment thread invisible_cities/icaros/selection_functions.py Outdated
Comment thread invisible_cities/icaros/selection_functions.py Outdated
Comment thread invisible_cities/icaros/selection_functions.py Outdated
Comment thread invisible_cities/icaros/selection_functions.py Outdated
Comment thread invisible_cities/icaros/selection_functions.py Outdated
mcidlaso added 17 commits January 16, 2026 14:48
@mcidlaso
Drop dropna() from normalization function
5f9baea
@mcidlaso
Add optional parameters in a single argument
a79497b
@mcidlaso
Import functions for creating krmaps and t_evol in the same file
b4b0895
@mcidlaso
Change description and correct create_empty_map function
0023370
@mcidlaso
Change name and add explanation comment in get_median() function
846c8be
@mcidlaso
Change function and variables names in gaussian_fit function
405d528
@mcidlaso
Change function name from map_3D_fits to fit_map
5c0f4c0
@mcidlaso
Changes in fit_map function
c4e94ea
@mcidlaso
Add description for merge_maps function
a86acf4
@mcidlaso
Change variable name for krmap in include_coordinates function
068f521
@mcidlaso
Change variable and function names in compute_3D_map function
ee5480c
@mcidlaso
Add function to get map info (metadata)
27065c5
@mcidlaso
Add functions (from icaros/krcal/core/fit_functions.py) to do fits
45f640c
@mcidlaso
Add function to divide dataframe into time slices
80eec15
@mcidlaso
Add function to calculate time evolution parameters
d3095fe
@mcidlaso
Add function to save map
fffafe1
@mcidlaso
Simplify select_lifetime_region function
de04df5
mcidlaso added 24 commits April 10, 2026 09:19
@mcidlaso
Changed function name to apply_correctionmap_inplace_kdst
c0a0b29
@mcidlaso
Changed tests to match function name change
1ff4ebf
@mcidlaso
ts is no longer previously defined
e93499c
@mcidlaso
Changed imports
9e2c168
@mcidlaso
Changed code style to match with IC and removed unnecessary imports a…
a4513bc 
…nd unnused variables
@mcidlaso
Changed energy unit argument in apply_3Dmap, apply_correctionmap_inpl…
81133f1 
…ace... now using system_of_units from invisible_cities.core. Also changed code style and removed unnecessary imports and variables
@mcidlaso
Changed resolution computation bc it was computing the energy resolut…
357265d 
…ion of the preliminary Ec.

Changed names of corrected energies in time evolution to be more
descriptive. Changed way of saving maps to avoid duplicated outputs
@mcidlaso
Changed code style to match IC. Removed unnecessary imports and varia…
3113414 
…bles
@mcidlaso
Changed names in MapFitFunction class
0a9c078
@mcidlaso
Modified code style to march with IC, modified functions to match the…
8e799c7 
… changes donde in apply_3Dmap and fit_functions
@mcidlaso
Changed fit_function and units variables to make the changes done in …
927d0a5 
…apply_3Dmap and compute_3Dmap
@mcidlaso
Changes in style and nbins_S2e is now nbins
c4ab008
@mcidlaso
Changes in style
679d842
@mcidlaso
Now get_median and gaussian_fit are functions of a variable and not o…
47d6ea4 
…f the whole dataframe.

Changes in style
@mcidlaso
Changes in tests to match the change in the arguments of get_median a…
4d8cbea 
…nd fit_function. Also changes in style
@mcidlaso
Changed test_select_1S1_1S2 and changes in style
389b01f
@mcidlaso
Removed unnecessary imports
6e18378
@mcidlaso
Removed col_name1 and col_name2
0d36f52
@mcidlaso
Removed commented code
bd1dd06
@mcidlaso
Removed col_name1 and col_name2 variables and commented code
7bd238e
@mcidlaso
Removed commented code and changed style for the tests
2e81489
@mcidlaso
Removed col_name1 and col_name2 from everywhere and adapted tests to …
a280cc3 
…match this change
@mcidlaso
Removed names variable from efficiencies plot, config, zemrude. Chang…
4973095 
…ed selection efficiency names
@mcidlaso
Changed test to match name change in total_efficiency
0d36ce1
gonzaponte
gonzaponte reviewed May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gonzaponte gonzaponte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few cosmetic changes and we are done. We will rewrite the history together to reduce the number of commits.

Comment thread invisible_cities/cities/zemrude.py Outdated
Comment thread invisible_cities/cities/zemrude.py Outdated
Comment thread invisible_cities/cities/zemrude.py Outdated
Comment thread invisible_cities/cities/zemrude.py Outdated
Comment thread invisible_cities/cities/zemrude.py Outdated
Comment thread invisible_cities/icaros/krmap_functions.py Outdated
Comment thread invisible_cities/icaros/krmap_functions.py Outdated
Comment thread invisible_cities/icaros/lifetime_vdrift_functions.py
Comment thread invisible_cities/icaros/lifetime_vdrift_functions.py
Comment thread invisible_cities/icaros/lifetime_vdrift_functions_test.py Outdated
gonzaponte
gonzaponte reviewed May 8, 2026
View reviewed changes
Comment thread invisible_cities/cities/zemrude.py Outdated
gonzaponte
gonzaponte reviewed May 8, 2026
View reviewed changes
Comment thread invisible_cities/cities/zemrude.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gonzaponte gonzaponte gonzaponte requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mcidlaso @gonzaponte