sysbox-fs/seccomp: add CIFS/SMB3 mount proxy#118
Open
VitorRamos wants to merge 1 commit intonestybox:masterfrom
Open
sysbox-fs/seccomp: add CIFS/SMB3 mount proxy#118VitorRamos wants to merge 1 commit intonestybox:masterfrom
VitorRamos wants to merge 1 commit intonestybox:masterfrom
Conversation
Author
|
Hi, We’ve been running into some SMB/CIFS mount limitations when using Sysbox. We’re currently testing it in our Coder setup (https://coder.com/docs/admin/templates/extending-templates/docker-in-workspaces), and so far this has been the main blocker. Would this kind of change be something you’d consider accepting? Thanks! |
Extend processNfsMount to also handle "cifs" and "smb3" filesystem types. The existing NFS proxy already does exactly what CIFS needs: re-issue mount(2) via nsenter as host root (AllNSsButUser), satisfying the kernel's requirement for CAP_SYS_ADMIN in the initial user namespace. - mount.go: add "cifs", "smb3" to the processNfsMount dispatch case; update function comment; use m.FsType in the debug log Tested: ubuntu:24.04, cifs-utils 7.0, guest share, vers=3.1.1 Fixes [#856](nestybox/sysbox#856) Signed-off-by: vramosgo <ramos.vitor89@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend processNfsMount to also handle "cifs" and "smb3" filesystem types. The existing NFS proxy already does exactly what CIFS needs: re-issue mount(2) via nsenter as host root (AllNSsButUser).
Tested: ubuntu:24.04, cifs-utils 7.0, guest share, vers=3.1.1
Fixes #856