Fix and add test for synapse post neuron transformer#1340
Draft
Fix and add test for synapse post neuron transformer#1340
Conversation
clinssen
force-pushed
the
test_synapse_post_neuron_transformer
branch
from
21fa79f to
466f775
Compare
added 2 commits
March 5, 2026 15:50
…former' into test_synapse_post_neuron_transformer
clinssen
force-pushed
the
test_synapse_post_neuron_transformer
branch
from
93f1feb to
8bf5c83
Compare
…euron_transformer
…ynapse_post_neuron_transformer
…former' into test_synapse_post_neuron_transformer
…ynapse_post_neuron_transformer
…euron_transformer
clinssen
force-pushed
the
test_synapse_post_neuron_transformer
branch
from
19f7984 to
170783d
Compare
clinssen
force-pushed
the
test_synapse_post_neuron_transformer
branch
from
170783d to
a816d44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a postsynaptic trace value gets requested by a synapse inside the postsynaptic event handling code, it could be possible that the trace is requested at a time precisely at that of the first spike in the history. If, additionally, the value "just before" the increment due to the spike was requested (i.e.
before_incrementis true), then the "just before increment" value needs to be computed based on a history entry correponding to the previous spike, which may have been already pruned. Fixing this requires an additional deep dive into the archiving logic and is postponed to a future PR.This PR does not completely fix this issue, but addresses it by means of:
SynapsePostNeuronTransformerby default);Thanks to @IiroAhokainen for reporting this issue!