Revise input and output ports in NESTML#1299
Draft
Conversation
added 30 commits
October 17, 2024 11:08
Co-authored-by: Pooja Babu <75320801+pnbabu@users.noreply.github.com>
clinssen
commented
Mar 27, 2026
| elif ctx.expression() is not None: | ||
| args.append(self.visit(ctx.expression())) | ||
| if name.upper() == "SIFT": | ||
| args[0].set_implicit_conversion_factor(1E3) # XXX: TODO: the factor 1E3 should be removed; see https://github.com/nest/nestml/issues/984 |
Contributor
Author
There was a problem hiding this comment.
To do: add a link from #984 back to this line of code.
added 15 commits
April 1, 2026 13:43
…into inhibitory_excitatory_remove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the NESTML predefined
sift()function to process spike events in event handlers. See here for documentation onsift(): https://github.com/nest/nestml/pull/1299/files#diff-22c1d3766680291b0aed3cd548fc0980ecc6511ebb5532a8ed2607105e1775e3R1198Remove the
excitatoryandinhibitoryspiking input port qualifiers. Instead, spikes should be routed (a) on the basis of having multiple spiking input ports (like one for excitatory and one for inhibitory input); or (b) on the basis of a condition likeA consequence of this is that spike ports can no longer be assumed to be linear and time-invariant in the general case (as in this case, a spike from the buffer will be processed differently depending on the sign of its weight). On the C++ side, this means that each spiking input port now uses the
VectorRingBufferclass (https://github.com/nest/nestml/pull/1299/files#diff-ee49404cf3290ce0e9ee40e25068b6d123da357aee83794ab89745a7e2aaf988R1) rather than theRingBuffer. The performance penalty of this is approximately 12.5% in a small balanced network example. An extra code generation option,linear_time_invariant_spiking_input_ports, is provided to instruct the NEST code generator that a set of given ports can be considered LTI. With this option enabled, performance is indistinguishable from the current main branch performance.Should be merged after #1288.Done.Should be merged after #1349.Done.Should be merged after #1358.
Replaces #1137.
Fixes #944.