Disambiguate physical units from declared variables#1295
Draft
Disambiguate physical units from declared variables#1295
Conversation
pnbabu
reviewed
Jan 15, 2026
| n_z integer = 2 | ||
| tau_d ms = 0.4 ms | ||
| tau_r ms = 20 ms | ||
| V mV = 123 mV |
Contributor
There was a problem hiding this comment.
Should we forbid this altogether? Users shouldn't be able to create variables with names that match unit types, right?
Contributor
Author
There was a problem hiding this comment.
This is not tenable as many units use letter that will be commonly used as parameter names, like a, b, c, d. Hence the "if it's not defined as a variable, it's a unit" rule.
|
|
||
| update: | ||
| integrate_odes() No newline at end of file | ||
| V = 1000 mV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1260.
Fixes #1010.