Fix MPI error for simulations using point-to-point communication #130
Merged
Fix MPI error for simulations using point-to-point communication #130
Conversation
JoseJVS
approved these changes
Mar 24, 2026
Collaborator
JoseJVS
left a comment
JoseJVS
left a comment
There was a problem hiding this comment.
Thank you @gmtiddia for bringing up these changes.
As we previously discussed, the changes for the initialization of MPI are necessary especially when interacting with additional frameworks such as mpi4py in the same simulation script.
Also cleaning up the pointer variable after delete is certainly necessary too to avoid double delete issues like those you saw with the MAM.
I agree with merging this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the double free or corruption error on cuRAND generator when performing simulations with point-to-point communications on 2.0 version.
Additionally, it adds the arguments to MPI Init, as done in this commit of @JoseJVS.
Spike times checked performing a MAM simulation and comparing to mpi_com (last commit: da2a463) using the same seed.