BUGFIX: build correct node uri for multisite setup for localhost#3548
Merged
BUGFIX: build correct node uri for multisite setup for localhost#3548
Conversation
skurfuerst
approved these changes
Apr 16, 2026
Member
skurfuerst
left a comment
There was a problem hiding this comment.
I fully understand the change now, and am extremely confident this does NOT break anything else. LGTM, let's get this in :)
skurfuerst
approved these changes
Apr 20, 2026
Member
skurfuerst
left a comment
There was a problem hiding this comment.
the updated approach looks good to me, but I'd love to have a second review - maybe by @kitsunet ?
kitsunet
approved these changes
Apr 20, 2026
Member
kitsunet
left a comment
There was a problem hiding this comment.
Thank you, this looks sensible to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a multi-site setup and linking from one site to another, the uri generation in development does not work correctly.
Scenario:
I have a neos site "main" with domain localhost, and "other" at domain other.localhost and want to link a node from main on other.
Expected behaviour:
The generated link points to "localhost/some-node"
Actual behaviour:
The generated link points to "other.localhost/some-node"
Changes:
check if
CONSTRAINT_HOSThas been set before falling back to base uriUpgrade instructions
There should be no breaking changes
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions