Skip to content

BUGFIX: build correct node uri for multisite setup for localhost#3548

Merged
kitsunet merged 3 commits intoneos:8.3from
anselmpaul:bugfix-crosssite-node-uri-localhost
Apr 20, 2026
Merged

BUGFIX: build correct node uri for multisite setup for localhost#3548
kitsunet merged 3 commits intoneos:8.3from
anselmpaul:bugfix-crosssite-node-uri-localhost

Conversation

@anselmpaul
Copy link
Copy Markdown
Collaborator

@anselmpaul anselmpaul commented Apr 13, 2026

When using a multi-site setup and linking from one site to another, the uri generation in development does not work correctly.

Scenario:
I have a neos site "main" with domain localhost, and "other" at domain other.localhost and want to link a node from main on other.

Expected behaviour:
The generated link points to "localhost/some-node"

Actual behaviour:
The generated link points to "other.localhost/some-node"

Changes:
check if CONSTRAINT_HOST has been set before falling back to base uri

Upgrade instructions
There should be no breaking changes

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Copy link
Copy Markdown
Member

@skurfuerst skurfuerst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully understand the change now, and am extremely confident this does NOT break anything else. LGTM, let's get this in :)

Copy link
Copy Markdown
Member

@skurfuerst skurfuerst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the updated approach looks good to me, but I'd love to have a second review - maybe by @kitsunet ?

Copy link
Copy Markdown
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks sensible to me.

@kitsunet kitsunet merged commit d73f430 into neos:8.3 Apr 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants