Skip to content

Add general efisetjmp_arch.h#93

Merged
ncroxon merged 1 commit into
ncroxon:masterfrom
calmsacibis995:fix-include
Mar 2, 2026
Merged

Add general efisetjmp_arch.h#93
ncroxon merged 1 commit into
ncroxon:masterfrom
calmsacibis995:fix-include

Conversation

@calmsacibis995
Copy link
Copy Markdown
Contributor

A header file needed by efisetjmp.h was created to fix an issue with efilib.h.

@gmbr3 gmbr3 changed the title Add a missing include file. Add general efisetjmp_arch.h Jan 1, 2026
Copy link
Copy Markdown
Collaborator

@gmbr3 gmbr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 😀 - it'll help for software which doesn't include the arch specific includedir

Changes needed:

  • Rename commit to something more informational like "Add generic efisetjmp_arch.h"
  • Signoff and GPG sign the commit e.g. git commit --amend --signoff -S

@gmbr3
Copy link
Copy Markdown
Collaborator

gmbr3 commented Jan 1, 2026

Build broken

@calmsacibis995
Copy link
Copy Markdown
Contributor Author

OK, the commit now has a verifed signature. I was spending some time figuring out on why on earth my commits are not being signed, but finally they are. Also, what exactly failed?

Copy link
Copy Markdown
Collaborator

@gmbr3 gmbr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase branch if possible - merge commits are annoying

@calmsacibis995
Copy link
Copy Markdown
Contributor Author

calmsacibis995 commented Jan 1, 2026

OK, I rebased the branch on master.

@calmsacibis995
Copy link
Copy Markdown
Contributor Author

I corrected a typo that causes the checks to fail on ia32.

@calmsacibis995
Copy link
Copy Markdown
Contributor Author

calmsacibis995 commented Jan 1, 2026

I corrected another typo that causes riscv checks to fail.

@calmsacibis995 calmsacibis995 requested a review from gmbr3 January 1, 2026 20:13
@calmsacibis995
Copy link
Copy Markdown
Contributor Author

I think now all checks are now going to pass.

Copy link
Copy Markdown
Collaborator

@gmbr3 gmbr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase (fixup) to one commit

Signed-off-by: Stefanos Stefanidis <www.fe32gr23@gmail.com>

Correct a typo.

Correct another typo.

Add check for 64-bit RISC-V platforms.

Fix another typo.

Add a common efisetjmp_arch.h
@calmsacibis995
Copy link
Copy Markdown
Contributor Author

OK, I there is now only a single commit.

@calmsacibis995 calmsacibis995 requested a review from gmbr3 January 5, 2026 14:18
@SamuraiCrow
Copy link
Copy Markdown

I have an old ARM-HF device that might benefit from this fix but it has been sitting unreviewed for 2 months as of tomorrow. If somebody can build a Debian install based on this I could test it.

@ncroxon ncroxon merged commit 8a45cdb into ncroxon:master Mar 2, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants