Add general efisetjmp_arch.h#93
Conversation
gmbr3
left a comment
There was a problem hiding this comment.
Thanks for this 😀 - it'll help for software which doesn't include the arch specific includedir
Changes needed:
- Rename commit to something more informational like "Add generic efisetjmp_arch.h"
- Signoff and GPG sign the commit e.g.
git commit --amend --signoff -S
|
Build broken |
|
OK, the commit now has a verifed signature. I was spending some time figuring out on why on earth my commits are not being signed, but finally they are. Also, what exactly failed? |
gmbr3
left a comment
There was a problem hiding this comment.
Rebase branch if possible - merge commits are annoying
173aae9 to
20baf91
Compare
|
OK, I rebased the branch on |
|
I corrected a typo that causes the checks to fail on ia32. |
|
I corrected another typo that causes riscv checks to fail. |
|
I think now all checks are now going to pass. |
gmbr3
left a comment
There was a problem hiding this comment.
Rebase (fixup) to one commit
Signed-off-by: Stefanos Stefanidis <www.fe32gr23@gmail.com> Correct a typo. Correct another typo. Add check for 64-bit RISC-V platforms. Fix another typo. Add a common efisetjmp_arch.h
dbc35a7 to
a9803a8
Compare
|
OK, I there is now only a single commit. |
|
I have an old ARM-HF device that might benefit from this fix but it has been sitting unreviewed for 2 months as of tomorrow. If somebody can build a Debian install based on this I could test it. |
A header file needed by
efisetjmp.hwas created to fix an issue withefilib.h.