Skip to content

feat(Highlight): add template string highlight support#67

Merged
nathansbradshaw merged 3 commits intonathansbradshaw:mainfrom
matthiaskomarek:feature/add-template-string-highlight
Nov 25, 2025
Merged

feat(Highlight): add template string highlight support#67
nathansbradshaw merged 3 commits intonathansbradshaw:mainfrom
matthiaskomarek:feature/add-template-string-highlight

Conversation

@matthiaskomarek
Copy link
Copy Markdown
Contributor

I have added highlight support for angular template strings which where added to angular with v19+.

I also updated the angular tree-sitter to the newest version

Before:
Bildschirmfoto 2025-11-17 um 19 57 51

After:
Bildschirmfoto 2025-11-17 um 19 56 30

Fixes #66

@nathansbradshaw
Copy link
Copy Markdown
Owner

@jpike88 @sheikalthaf @nevadascout Do any of you have the capacity to test and approve this PR?

@jpike88
Copy link
Copy Markdown
Collaborator

jpike88 commented Nov 20, 2025

works for me at a glance but i don't use template strings inline like that so i'm not much use for finding edge cases

@syntlyx
Copy link
Copy Markdown

syntlyx commented Nov 20, 2025

Need to update tree-sitter to latest version, see #66

@matthiaskomarek
Copy link
Copy Markdown
Contributor Author

Thanks for the review, i could update the tree-sitter to the latest tag version 0.7.1

And do another MR when the next version of the tree-sitter is released with the bugfix @syntlyx mentioned.

@matthiaskomarek
Copy link
Copy Markdown
Contributor Author

matthiaskomarek commented Nov 21, 2025

MR is updated to the latest tag release of tree-sitter (0.8.0)

Copy link
Copy Markdown
Collaborator

@jpike88 jpike88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nathansbradshaw nathansbradshaw merged commit 05f8c2f into nathansbradshaw:main Nov 25, 2025
1 check passed
github-merge-queue Bot pushed a commit to zed-industries/extensions that referenced this pull request Mar 18, 2026
Includes: 

- Diff:
nathansbradshaw/zed-angular@v0.0.4...v0.0.5
- nathansbradshaw/zed-angular#84
- nathansbradshaw/zed-angular#80
- nathansbradshaw/zed-angular#82
- nathansbradshaw/zed-angular#67
- nathansbradshaw/zed-angular#60

Update tree-sitter-angular to v0.8.3:

- Diff:
dlvandenberg/tree-sitter-angular@8b4f7e6...f0d0685
- Complex CSS classes breaking parsing
- Template string as primitive
- Hyphen in identifier
- Percentage sign as unit for style property binding
- Class attribute modifier starting with hyphen

Closes: nathansbradshaw/zed-angular#71
cramhead pushed a commit to cramhead/extensions that referenced this pull request Mar 31, 2026
Includes: 

- Diff:
nathansbradshaw/zed-angular@v0.0.4...v0.0.5
- nathansbradshaw/zed-angular#84
- nathansbradshaw/zed-angular#80
- nathansbradshaw/zed-angular#82
- nathansbradshaw/zed-angular#67
- nathansbradshaw/zed-angular#60

Update tree-sitter-angular to v0.8.3:

- Diff:
dlvandenberg/tree-sitter-angular@8b4f7e6...f0d0685
- Complex CSS classes breaking parsing
- Template string as primitive
- Hyphen in identifier
- Percentage sign as unit for style property binding
- Class attribute modifier starting with hyphen

Closes: nathansbradshaw/zed-angular#71
pataruco pushed a commit to pataruco/extensions that referenced this pull request Apr 15, 2026
Includes: 

- Diff:
nathansbradshaw/zed-angular@v0.0.4...v0.0.5
- nathansbradshaw/zed-angular#84
- nathansbradshaw/zed-angular#80
- nathansbradshaw/zed-angular#82
- nathansbradshaw/zed-angular#67
- nathansbradshaw/zed-angular#60

Update tree-sitter-angular to v0.8.3:

- Diff:
dlvandenberg/tree-sitter-angular@8b4f7e6...f0d0685
- Complex CSS classes breaking parsing
- Template string as primitive
- Hyphen in identifier
- Percentage sign as unit for style property binding
- Class attribute modifier starting with hyphen

Closes: nathansbradshaw/zed-angular#71
loczek pushed a commit to loczek/zed-extensions that referenced this pull request May 4, 2026
Includes: 

- Diff:
nathansbradshaw/zed-angular@v0.0.4...v0.0.5
- nathansbradshaw/zed-angular#84
- nathansbradshaw/zed-angular#80
- nathansbradshaw/zed-angular#82
- nathansbradshaw/zed-angular#67
- nathansbradshaw/zed-angular#60

Update tree-sitter-angular to v0.8.3:

- Diff:
dlvandenberg/tree-sitter-angular@8b4f7e6...f0d0685
- Complex CSS classes breaking parsing
- Template string as primitive
- Hyphen in identifier
- Percentage sign as unit for style property binding
- Class attribute modifier starting with hyphen

Closes: nathansbradshaw/zed-angular#71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Templated strings not supported in Angular HTML (19+)

4 participants