Improve header paths in generated C++ code#965
Merged
Conversation
Add getNeighborPath function Refactor getIncludePath to use it
Fix include headers
Revise include paths
Revise header paths
Revise include paths
Revise include paths
Revise include paths
Revise include paths
Revise include paths
Kronos3
reviewed
Mar 23, 2026
Collaborator
Kronos3
left a comment
There was a problem hiding this comment.
Does this need to be updated as well?
Collaborator
Author
I don't see a way to update that one, because |
Kronos3
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For header files tied to an FPP definition, use the location of the definition as the location of the header. Before we were using the current directory (where the analysis is run) in some cases.
check-cppFppTestCloses #880.