ccollins/CUMULUS 4428 Add Input Granules#4283
Draft
ccollinsuah wants to merge 15 commits intomasterfrom
Draft
Conversation
ccollinsuah
force-pushed
the
ccollins/cumulus-4428
branch
from
bbcfa18 to
d8e7884
Compare
ccollinsuah
changed the title
| "required": [ | ||
| "name", | ||
| "path", | ||
| "archivePath" |
Contributor
There was a problem hiding this comment.
It might be better to leave archivePath off as required. Since it's not necessary for this task and I'm not sure if the pdr object will always have it, but I don't think it hurts leaving it as required
Author
There was a problem hiding this comment.
Yeah, I was on the fence on whether or not it should be marked as required since I lacked some context on whether subsequent PDR tasks would break if it wasn't present for pass through. I went ahead and removed it as a required field.
Batches calls to Cumulus API when getting executions for the Add-Inpu…
ccollinsuah
force-pushed
the
ccollins/cumulus-4428
branch
2 times, most recently
from
8f1cf83 to
59f8302
Compare
ccollinsuah
force-pushed
the
ccollins/cumulus-4428
branch
from
5c8d186 to
8c43c10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Summary of changes
Addresses CUMULUS-4428: Upgrade Python version of Add Input Granules task
Changes
PR Checklist
📝 Note:
For most pull requests, please Squash and merge to maintain a clean and readable commit history.