Open
Conversation
Nnaga1
reviewed
Feb 23, 2026
Contributor
Nnaga1
left a comment
Nnaga1
left a comment
There was a problem hiding this comment.
Just had a question/comment 👀
| WaitTimeSeconds: 10, | ||
| }); | ||
| const snsMessageBody = JSON.parse(Messages[1].Body); | ||
| const publishedMessage = JSON.parse(snsMessageBody.Message); |
Contributor
There was a problem hiding this comment.
so above you added receiving a create message -> testing/asserting it -> receive an update message -> testing and asserting, and these changes are basically that where instead of 2 (MaxNumberOfMessages: 2,) you check for the one you just received (the create one), if im understanding correctly and that fixes the race condition
Member
Author
There was a problem hiding this comment.
yeah, ordering isn't ensured, so occasionally the test would fail.
Contributor
There was a problem hiding this comment.
awesome, thanks for confirming 🙌
Nnaga1
approved these changes
Feb 26, 2026
Contributor
Nnaga1
left a comment
Nnaga1
left a comment
There was a problem hiding this comment.
LGTM 🙌 thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Summary of changes
Addresses CUMULUS-4556: Develop amazing new feature
This PR includes a minor reliability fix in a unit I noted was intermittently failing during my eval work for 4556.
Changes
PR Checklist
📝 Note:
For most pull requests, please Squash and merge to maintain a clean and readable commit history.