Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughUpdated Leiningen dependency declarations across multiple projects to exclude Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@common-lib/project.clj`:
- Around line 8-9: Update the jackson-dataformat-cbor exclusion so its version
matches jackson-core (2.18.6); specifically replace any occurrences of
com.fasterxml.jackson.dataformat/jackson-dataformat-cbor pinned to an older
version with version 2.18.6 to align with
com.fasterxml.jackson.core/jackson-core, and make the same change for the other
exclusion instance referenced (the one around lines 21–23) to ensure consistent
Jackson versions across the project.clj exclusions.
In `@message-queue-lib/project.clj`:
- Around line 14-15: The project.clj dependency list pins "jackson-annotations"
to 2.15.4 which conflicts with the root's managed version 2.18.6; update the
"jackson-annotations" entry in project.clj (the dependency vector named
jackson-annotations) to match 2.18.6 or remove the explicit version so it
inherits the root-managed version, ensuring consistency across Jackson modules.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d414e971-eead-43cf-88d8-10b8b75497b3
📒 Files selected for processing (12)
access-control-app/project.cljbootstrap-app/project.cljcommon-app-lib/project.cljcommon-lib/project.cljelastic-utils-lib/project.cljmessage-queue-lib/project.cljmetadata-db-app/project.cljproject.cljschema-validation-lib/project.cljsearch-app/project.cljsearch-relevancy-test/project.cljsystem-int-test/project.clj
aa05a25 to
a05f78f
Compare
a05f78f to
396e315
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2404 +/- ##
==========================================
- Coverage 57.90% 57.89% -0.01%
==========================================
Files 1067 1067
Lines 73454 73454
Branches 2126 2124 -2
==========================================
- Hits 42531 42529 -2
- Misses 28942 28943 +1
- Partials 1981 1982 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overview
What is the objective?
Updates jackson-core to resolve snyk report on Chesire. Currently updating to cheshire 6.2 doens't work due to some interactions with testcontainers so for this solution I'm just forcing a valid version of jackson-core, avoiding the transitive dependency.
What are the changes?
Updates project.clj in affected apps
Required Checklist
Additional Checklist
Summary by CodeRabbit