Skip to content

Get rid of spread operator for prop key#42

Open
JimTeva wants to merge 1 commit inton4kz:masterfrom
JimTeva:patch-1
Open

Get rid of spread operator for prop key#42
JimTeva wants to merge 1 commit inton4kz:masterfrom
JimTeva:patch-1

Conversation

@JimTeva
Copy link
Copy Markdown

@JimTeva JimTeva commented Sep 28, 2024

key is a special prop in React that's used for reconciliation. React recommends handling it separately from other props.
Generates errors in react-native v75.3 if not handled properly.

key is a special prop in React that's used for reconciliation. React recommends handling it separately from other props.
@charlestbell
Copy link
Copy Markdown

+1

1 similar comment
@OmarSaidIbrahim
Copy link
Copy Markdown

+1

@deelo55
Copy link
Copy Markdown

deelo55 commented Nov 22, 2024

I've forked and published the fix here:
https://www.npmjs.com/package/@deelo55/react-native-indicators

@Akatroj
Copy link
Copy Markdown

Akatroj commented Dec 3, 2024

@JimTeva your MR fixes the issue only for BallIndicator component, here is my patch for every indicator type: #43 (comment)

@celleb
Copy link
Copy Markdown

celleb commented Jan 6, 2025

This seems like an abandoned project, last release was 5 years ago. Anyone planning on creating a new fork that will keep up with RN/react?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants