feat(proto): Mark PathEvent as #[non_exhaustive]#648
Open
matheus23 wants to merge 2 commits into
Open
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/noq/pr/648/docs/noq/ Last updated: 2026-05-12T14:25:21Z |
Performance Comparison Report
|
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5659.8 Mbps | 7948.1 Mbps | -28.8% | 97.5% / 148.0% |
| medium-concurrent | 5395.0 Mbps | 8028.9 Mbps | -32.8% | 95.9% / 147.0% |
| medium-single | 4384.6 Mbps | 4580.7 Mbps | -4.3% | 92.0% / 101.0% |
| small-concurrent | 3809.5 Mbps | 5261.4 Mbps | -27.6% | 94.3% / 101.0% |
| small-single | 3588.7 Mbps | 4801.6 Mbps | -25.3% | 98.0% / 151.0% |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | 3063.9 Mbps | N/A | N/A |
| lan | 782.4 Mbps | N/A | N/A |
| lossy | 69.8 Mbps | N/A | N/A |
| wan | 83.8 Mbps | N/A | N/A |
Summary
noq is 25.4% slower on average
flub
reviewed
May 13, 2026
|
|
||
| /// Application events about paths | ||
| #[derive(Debug, Clone, PartialEq, Eq)] | ||
| #[non_exhaustive] |
Collaborator
There was a problem hiding this comment.
I think we need non-exhaustive on the event fields as well. I think e.g. iroh would benefit from adding the remote address to Established and that would be nice to be able to do without breaking the API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is for future-proofing the API.
Closes #642
Breaking Changes
enum PathEventis now marked as#[non_exhaustive]Notes & open questions
I'm ignoring the
_ =>case, as anything else would mean we would "do something" in case e.g. noq is bound against a newer noq-proto.In
#[cfg(test)]however, I panic, as in that case the version we depend on must be up to date.Change checklist