-
Notifications
You must be signed in to change notification settings - Fork 13
Add linklocal4 addresses to regular addresses #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zh522130
wants to merge
10
commits into
n0-computer:main
Choose a base branch
from
zh522130:add-linklocal4-to-regular
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c1a3569
Include IPv4 link-local addresses in the regular field
zh522130 09d215a
use chain to combine extend operations
zh522130 5f367fe
update comments
zh522130 741c4e8
Merge branch 'n0-computer:main' into add-linklocal4-to-regular
zh522130 3f2c5c7
Merge branch 'n0-computer:main' into add-linklocal4-to-regular
zh522130 879c4c6
add link_local field to LocalAddresses
zh522130 afb7c79
separate link-local from regular addresses
zh522130 7678d9c
include IPv6 link-local addresses in link_local field
zh522130 87ad20e
Merge branch 'n0-computer:main' into add-linklocal4-to-regular
zh522130 be232f1
Merge branch 'n0-computer:main' into add-linklocal4-to-regular
zh522130 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a significant behaviour change that requires carefully looking at everywhere this is used in iroh.
Likely I'm in favour of this, and would even go further and also give ula6 addresses their own category. But the whole topic needs a lot of careful looking at how all this is used in iroh and how it should work.