test(iroh): fix racy connection shutdown#4243
Open
flub wants to merge 2 commits into
Open
Conversation
Waiting for stopped when the peer is about to shutdown is flaky and not the recommended shutdown protocol. The CONNECTION_CLOSE could be sent before all packets have been acked. And if the close arrives before some acks then stopped (on the server) will fail with an error. CONNECTION_CLOSE is supposed to include any un-acked packets, but this is only a best-effort and not a guarantee. This may not include all packets if an ACK was already considered in-flight.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4243/docs/iroh/ Last updated: 2026-05-07T15:06:27Z |
dignifiedquire
approved these changes
May 7, 2026
dignifiedquire
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Waiting for stopped when the peer is about to shutdown is flaky and
not the recommended shutdown protocol. The CONNECTION_CLOSE could be
sent before all packets have been acked. And if the close arrives
before some acks then stopped (on the server) will fail with an
error.
CONNECTION_CLOSE is supposed to include any un-acked packets, but this
is only a best-effort and not a guarantee. This may not include all
packets if an ACK was already considered in-flight.
Breaking Changes
n/a
Notes & open questions
QUIC shutdown, it still gets us...
Change checklist