Skip to content

feat(iroh-relay): expose Bucket rate-limit primitive#4242

Merged
dignifiedquire merged 2 commits into
mainfrom
feat-bucket-rate
May 7, 2026
Merged

feat(iroh-relay): expose Bucket rate-limit primitive#4242
dignifiedquire merged 2 commits into
mainfrom
feat-bucket-rate

Conversation

@dignifiedquire
Copy link
Copy Markdown
Contributor

Updated version of #4231

Embedders that mount the relay protocol via custom HTTP servers (e.g. axum integration in holochain/kitsune2) cannot use the existing RateLimited<S: AsyncRead> wrapper because their stream layer is already WS-framed by the time the relay handler runs. Exposing Bucket lets these embedders apply iroh's bucket semantics at the frame layer.

Visibility-only change: Bucket struct, Bucket::new and Bucket::consume become pub. Fields stay private. InvalidBucketConfig was already pub. Adds rustdocs to satisfy deny(missing_docs).

No behavior change.

Embedders that mount the relay protocol via custom HTTP servers
(e.g. axum integration in holochain/kitsune2) cannot use the existing
RateLimited<S: AsyncRead> wrapper because their stream layer is already
WS-framed by the time the relay handler runs. Exposing Bucket lets these
embedders apply iroh's bucket semantics at the frame layer.

Visibility-only change: Bucket struct, Bucket::new and Bucket::consume
become pub. Fields stay private. InvalidBucketConfig was already pub.
Adds rustdocs to satisfy deny(missing_docs).

No behavior change.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4242/docs/iroh/

Last updated: 2026-05-07T15:04:08Z

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: e90e088

@dignifiedquire dignifiedquire added this to the v1.0.0-rc.1 milestone May 7, 2026
@n0bot n0bot Bot added this to iroh May 7, 2026
@github-project-automation github-project-automation Bot moved this to 🚑 Needs Triage in iroh May 7, 2026
@dignifiedquire dignifiedquire moved this from 🚑 Needs Triage to 👀 In review in iroh May 7, 2026
@dignifiedquire dignifiedquire merged commit f8cd43c into main May 7, 2026
37 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in iroh May 7, 2026
@dignifiedquire dignifiedquire deleted the feat-bucket-rate branch May 7, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants