Merging latest changes from ContactPage#1
Open
jeffw16 wants to merge 470 commits intomywikis:masterfrom
Open
Conversation
Bug: T349951 Change-Id: Ic17a76a51087cb96524146b2b2351e28fefcf024
Change-Id: Idf82c2fd64858c01b9b1f20390feff16dbdfad15
Change-Id: I3b92fd4d856849f334750e55edc796ed0c2a1a0f
Change-Id: I9582d59716439ecbc57138a62739000d04d061dd
Change-Id: Id4def644018191df3eb413f6abb03ad0441107ff
User-options related classes are being moved to the MediaWiki\User\Options namespace in MediaWiki Core; reflect that change here. Bug: T352284 Depends-On: I9822eb1553870b876d0b8a927e4e86c27d83bd52 Change-Id: I500e8e241f1ef7ab3f1bc309371d534d3f3e573d
Change-Id: I0e28ace7996d222f4e3de33bf8fbad9b256217b0
Done automatically via script Change-Id: I236c8d3c1b9f083b5c3e64c52ad2df76a635fc5e
Change-Id: Iabc7f9f97d9c399bf251bf140f745755f3c7d735
Change-Id: Ia31461f20e820477e45fe631a1c05dfccbeadf38
Change-Id: I9e612694af72617d3364a84b5e8888ff50165be4
Change-Id: I96f861d5b6aa6f41c07e7d7e398f9898c336be58
Change-Id: I2ac135f19d4a8cc33cb6da73f4358e7f2354427e
Change-Id: I10fbd0f3336ddec78be6db105f278aacb09acdff
Follows-up I4c85a2042ae591732b48bbf. Change-Id: Ib7faf0e686bc250f3332e75b4af3822f15c332a7
Change-Id: I63653e60c64c6aaa365396cb355e8cf1dd087e0e
On EnWiki, we found that allowing users to change their name and email allows them to impersonate other users which in our usecase would be a major problem. This patch adds the following new config variables: - NameReadonly: makes the Name field read-only (false by default) - EmailReadonly: makes the Email field read-only (false by default) - SubjectReadonly: makes the Subject field read-only (false by default) - MustHaveEmail: whether to require the sender to have a confirmed email for accessing the form (false by default) If the form allows anyone to submit, these config options do nothing. If users are required to log in, and these options are set to true, then these inputs are populated with the username and email with editing of them disabled. Bug: T324175 Change-Id: I4820c1effc213a2cba452f00b65c90d287ec2172
…ation Why: * Comments were left on the patch merged as 6012864 indicating issues with the implementation of the patch. * This follow-up change addresses these concerns, including giving a more detailed error description for missing a confirmed email address and disallowing invalid configuration. What: * Add contactpage-musthaveemail-error-title and contactpage- musthaveemail-error which are used instead of noemail and noemailtitle for when a confirmed email address is not attached to an account. * Make the following configurations disallowed and to cause the contact page to not display: ** 'EmailReadonly' set to true, 'MustBeLoggedIn' set to false, and 'RequireDetails' set to true ** 'MustHaveEmail' set to true and 'MustBeLoggedIn' set to false. * Update the README for changes made, including fixing the listed example configuration. Bug: T324175 Change-Id: I2074c800987c91d53f589ffcc717557e46684092
Change-Id: I00ea645607baa2279551451bc093b9886b2edc9f
Change-Id: I5630f9a814639a0775f2e80f32bb038b8235fdb1
Change-Id: Ibe5dec2966ba25b9d312245eaf4bd27903dc82ce
Change-Id: I9757c2dd9df3d60cc24de4177819acb17d60a6fb
Change-Id: I86c6ed77d183e5f2a489532709e6310ebbe57855
Change-Id: Ie1d125de45bc6d78520fafe8397ce66c59af68d1
Change-Id: Ib1d6a1aa1d11d8d3b737c2b93272639694b7e143
Change-Id: Ie407e072bfe6e28d9d97647ed92cd0d124facc7a
Change-Id: I2098bcf0ec4c5e5defad7a7e558b625fa7522937
* GHSA-73rr-hh4g-fpgx Change-Id: I4e9e6ce87d0ad1d4ce85237a7b618628f6c50c43
* GHSA-xxjr-mmjv-4gpg Change-Id: I71e421e53e72b51d935ae82ce7bdf4d14454ab18
Change-Id: I719c2c82a45802dcaea5e5fb715b0ed471157b54
Change-Id: Icb6e71b30422efe7f6e5b281f37839ef00037f61
Change-Id: I78d04b8d3db6b8da4b61bd2b4f00f394022e3438
Change-Id: I0f19297d7dfd0178903f89d256eb0fd0b93d255a
Bug: T415543 Change-Id: Id9cfee292a73cde4fdd9b92666f2352127bc3c99
If `requireDetails` config option is falsey, the user may supply username or emailaddress or both. The first one provided is appended to the subject line. The other value is discarded. If `requireDetails` config option is truthy, the username is always appended to the subject. The emailaddress, which must be provided, is discarded. This patch adds the emailaddress to the email body in these cases where it is supplied and discarded currently. Bug: T416915 Change-Id: I55b19c11f5022d6e3d5194dabe82cc934eee091b
composer: * mediawiki/minus-x: 1.1.3 → 2.0.1 npm: * ajv: 6.12.6 → 6.14.0 * GHSA-2g4f-4pwh-qvx6 * fast-xml-parser: 5.2.5 → 5.3.7 * GHSA-37qj-frw5-hhjh * GHSA-jmr7-xgp7-cmfj * GHSA-m7jm-9gc2-mpf2 Change-Id: I88ef0d3d066180a9a570b24281e94d6ee36f70f5
Change-Id: Idd04fe1a444cbdcd6e8e5a0f857d0395e18f5b43
Change-Id: I54245d10d453d152952b3046c825020ddce1e8c1
composer: * mediawiki/mediawiki-codesniffer: 49.0.0 → 50.0.0 * mediawiki/mediawiki-phan-config: 0.18.0 → 0.19.0 npm: * basic-ftp: 5.0.5 → 5.2.0 * GHSA-5rq4-664w-9x2c * fast-xml-parser: 5.3.7 → 5.4.1 * GHSA-fj3w-jwp8-x2g3 Change-Id: I231deaa84e13b60c0aaa2eddb667ecdad6c031a7
Change-Id: Iad41085ddca61d3df78710cf2e43e479a97c0dd4
Change-Id: I086bde076ad13c8655f2d523d85ded9526bad7f2
* flatted: 3.3.3 → 3.4.1 * GHSA-25h7-pfq9-p65f * undici: 6.23.0, 7.18.2 → 6.24.0, 7.24.1 * GHSA-2mjp-6q6p-2qxm * GHSA-4992-7rv2-5pvq * GHSA-f269-vfmq-vjvj * GHSA-phc3-fgpg-7m6h * GHSA-v9p9-hfj2-hcw8 * GHSA-vrm6-8vpv-qv8q Change-Id: Iace81386e72081cc84a205ec197d5a465859a802
Change-Id: I5958bf06495ba0e66efc79a0e229eb20d41c40fc
Change-Id: I8e007e22b6d09ab519d84f04c621a49e28562c9d
* fast-xml-parser: 5.4.1 → 5.5.8 * GHSA-8gc5-j5rx-235r * GHSA-jp2q-39xq-3w4g * flatted: 3.4.1 → 3.4.2 * GHSA-rf6f-7fwh-wjgh Change-Id: If5dc0a76a638cc5671269e5bc660b0a8d1a04cfa
Change-Id: Icf51bb6988b91f3b7cad09482a33dc282e1e67de
* picomatch: 2.3.1, 4.0.3 → 2.3.2, 4.0.4 * GHSA-3v7f-55p6-f55p * GHSA-c2c7-rcm5-vvqj * yaml: 2.8.1 → 2.8.3 * GHSA-48c2-rrv3-qjmp Change-Id: Ib17899270d14ac0b840098e1ef663b65f2d07dfc
* GHSA-f886-m6hf-6m8v Change-Id: I280c2256a7e72ed532524e15093d4be618cb558b
Change-Id: If5c05fabf844d9479126259123fec67fb18ac83c
* GHSA-chqc-8p9q-pq6q Change-Id: I6b3bf7f3666ff9374c708f91c6a95a9107a33029
* GHSA-6v7q-wjvx-w8wg Change-Id: I38e4b31a98ef2adc8c0dfc2caaeb5a38c4281d24
Changes to the use statements done automatically via script Change-Id: I289a27003ec91d200ea4dfb20e584ee96d18fa7e
* grunt: 1.6.1 → 1.6.2 * grunt-legacy-log: 3.0.0 → 3.0.1 * GHSA-f23m-r3pf-42rh * GHSA-r5fr-rjxr-66jc * grunt-legacy-util: 2.0.1 → 2.0.2 * GHSA-f23m-r3pf-42rh * GHSA-r5fr-rjxr-66jc * lodash: 4.17.23 → 4.18.1 * GHSA-f23m-r3pf-42rh * GHSA-r5fr-rjxr-66jc Change-Id: Ibccbf791833149928fbd81196dce34ca6e9491a1
Change-Id: I05986498f75b2e0792ddb3433f0c357c67f2f120
* GHSA-rp42-5vxx-qpwr Change-Id: I958f63e2769c806d67e6703d01dd493f59103edb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.