Issue with Class level PostData/Query Param Data not being reset after every curl call#6
Open
dennismonsewicz wants to merge 2 commits intomyemma:masterfrom
Open
Issue with Class level PostData/Query Param Data not being reset after every curl call#6dennismonsewicz wants to merge 2 commits intomyemma:masterfrom
dennismonsewicz wants to merge 2 commits intomyemma:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request addresses issues where if you are iterating over a set of data and have initialized a new Emma class outside of the loop, the post data/query param data is being overwritten every time a curl call is made.
Lines 1045-1046 address this issue by simply resetting the class level post/params array
UnitTest coverage/fixes coming soon