Fix missing class variables on cdef classes and inconsistent implemen…#2
Merged
mxmlnkn merged 2 commits intomxmlnkn:masterfrom Nov 17, 2025
Merged
Conversation
mxmlnkn
reviewed
Nov 17, 2025
| cdef class _BKTree: | ||
| cdef CppBKTree[vector[uint8_t], size_t]* tree | ||
| cdef int max_element_count | ||
| cdef bool _needs_rebalance |
Owner
There was a problem hiding this comment.
Is this necessary? It worked fine without it. Honest question because I am not too well-versed with Cython.
Contributor
Author
|
I believe it is, for me it didn’t work without it (different cython
versions? Didn’t look to see if that’s pinned to a specific version)
…On Mon, Nov 17, 2025 at 9:20 AM Maximilian Knespel ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In cppbktree/cppbktree.pyx
<#2 (comment)>:
> @@ -82,6 +82,8 @@ cdef extern from "cppbktree.hpp":
cdef class _BKTree:
cdef CppBKTree[vector[uint8_t], size_t]* tree
+ cdef int max_element_count
+ cdef bool _needs_rebalance
Is this necessary? It worked fine without it.
—
Reply to this email directly, view it on GitHub
<#2 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJO3Q2UYEDFZ776QXL6BOT35HYU5AVCNFSM6AAAAACLTQJLXWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTINZTGUZTOOBUHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing class variables on cdef classes and inconsistent implementation of rebalance