fix: robust 429 retry in get_data.sh prevents 0-byte test data files#260
Merged
fix: robust 429 retry in get_data.sh prevents 0-byte test data files#260
Conversation
…0-byte test data files Agent-Logs-Url: https://github.com/mwang87/MassQueryLanguage/sessions/b86a5a85-c2cb-4848-beee-f29e1e1d10c8 Co-authored-by: mwang87 <96528+mwang87@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
mwang87
April 8, 2026 04:15
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
massiveproxy.gnps2.orgrate-limits to ~10 req/min. The previouswget-based download loop (3 retries, 5s waitretry) exhausted all attempts within the same rate-limit window and — critically —wget --output-documentalways creates the output file, even on total failure. Tests then received 0-byte files and died withlxml.etree.XMLSyntaxError: no element foundrather than a meaningful download error.Changes
wget→curlwith HTTP status capture (-w "%{http_code}"), enabling reliable 429 detection at the shell levelrm -fthe output before sleeping, eliminating the 0-byte artifact that silently poisoned tests-s(non-empty file) check