Merged
Conversation
Removes HTTPT struct, telemetry_thread, and all related MQTT publishing from the HTTP server core. The mqtt370 dependency is also removed from project.toml. Affected files: - include/httpd.h: removed HTTPT/HTTPTC typedefs and struct definitions, replaced httpt field at offset 0x94 with void *unused_94, replaced mqtc_pub slot at offset 0x10C with void *unused_10C - include/httpcgi.h: same HTTPX slot replacement, removed MQTC typedef - include/httppub.h: deleted - src/httpx.c: NULL placeholder at offset 0x10C - src/httpd.c: removed telemetry_thread, http_process_telemetry*, related MQTT publish calls, and unused variables - src/httpdsrv.c: removed httpt display row - src/httpstat.c: removed http_pubf calls and now-unused variables - src/httppubf.c: deleted - project.toml: removed mqtt370 dependency Fixes #44
The http_lua_publish() function referenced HTTPT, MQTC, and mqtc_pub which no longer exist after the MQTT telemetry removal. Replace the function body with a stub that returns "not available". Fixes #44
…sh stub httpd048.c still called http_pubf() (MQTT telemetry), causing unresolved external HTTP@PUB at link time. http_lua_publish() stub used lua_pushinteger which expands via HTTPLUAX macro to httpd->luax, requiring an httpd pointer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the MQTT telemetry subsystem from the HTTP server core, as decided for HTTPD 4.0.0.
Changes
include/httpd.h: RemovedHTTPT/HTTPTCstruct definitions and typedefs. Field at offset0x94(wasHTTPT *httpt) replaced withvoid *unused_94for ABI stability.HTTPXslot at0x10C(wasmqtc_pub) replaced withvoid *unused_10C.include/httpcgi.h: SameHTTPXslot replacement, removedMQTCtypedef.include/httppub.h: Deleted.src/httpx.c:NULLplaceholder at offset0x10C.src/httpd.c: Removedtelemetry_thread,http_process_telemetry*helper functions, allhttp_pubf/http_pub_datetimecalls, and now-unused local variables.src/httpdsrv.c: Removedhttptdisplay row from server status page.src/httpstat.c: Removedhttp_pubfcalls and the now-unused counter variables.src/httppubf.c: Deleted.project.toml: Removedmqtt370dependency.Fixes #44