fix!: identity hash is SyncMultihashHasher<0>#337
Merged
Conversation
Member
Author
|
This PR targets #335 to reduce exposure to merge conflicts - it should be merged into master shortly after that one goes in. |
lidel
approved these changes
May 5, 2026
achingbrain
force-pushed
the
fix/identity-as-multihash-hasher
branch
3 times, most recently
from
f570ca1 to
465b8a6
Compare
Updates the type of the identity hash to `SyncMultihashHasher<0x00>` to enable passing it where `MultihashHasher<Code>` instances are expected. It was also necessary to update the returned type of `from` to be `MultihashHasher<Code>` instead of the concrete `Hasher` type which has extra properties that are not part of hashing. Fixes #313 Supersedes #314 BREAKING CHANGE: all `Hasher`s are now `MultihashHasher<Code>`s
achingbrain
force-pushed
the
fix/identity-as-multihash-hasher
branch
from
465b8a6 to
96e2da3
Compare
github-actions Bot
pushed a commit
that referenced
this pull request
May 7, 2026
## [14.0.0](v13.4.2...v14.0.0) (2026-05-07) ### ⚠ BREAKING CHANGES * all `Hasher`s are now `MultihashHasher<Code>`s * Returned `Uint8Array`s are now `Uint8Array<ArrayBuffer>` ### Bug Fixes * identity hash is SyncMultihashHasher<0> ([#337](#337)) ([9b5b12b](9b5b12b)), closes [#313](#313) [#314](#314) * specify type of backing buffer when Uint8Arrays are returned ([#335](#335)) ([bac2da5](bac2da5))
|
🎉 This PR is included in version 14.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the type of the identity hash to
SyncMultihashHasher<0x00>to enable passing it whereMultihashHasher<Code>instances are expected.It was also necessary to update the returned type of
fromto beMultihashHasher<Code>instead of the concreteHashertype which has extra properties that are not part of hashing.Fixes #313
Supersedes #314
BREAKING CHANGE: all
Hashers are nowMultihashHasher<Code>s