fix(inbox): refetch missing highlighted comment#2907
Open
furtherref wants to merge 1 commit into
Open
Conversation
|
@furtherref is attempting to deploy a commit to the IndexLabs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an Inbox deep-link edge case where
IssueDetailcan reopen an issue with a timeline query that is still considered fresh, but the cached timeline does not contain thehighlightCommentIdtarget yet. In that state, the existing scroll/highlight effect has no DOM node to land on.This keeps the recovery scoped to the highlighted-comment path: after the issue and timeline finish loading, if the loaded timeline is missing the target comment,
IssueDetailinvalidates that issue timeline once so TanStack Query fetches the authoritative timeline and the existing scroll/highlight behavior can proceed.Related Issue
No exact upstream issue found. Related prior deep-link work: #2332 and #2472.
Type of Change
Changes Made
packages/views/issues/components/issue-detail.tsx: detect a missing highlighted comment in a loaded timeline and invalidate that issue timeline once per issue/comment pair.packages/views/issues/components/issue-detail.test.tsx: seed a fresh but incomplete timeline cache and assert that the target comment is refetched, rendered, and scrolled into view.How to Test
pnpm --filter @multica/views exec vitest run issues/components/issue-detail.test.tsx -t "highlightCommentId scroll-to-comment"pnpm --filter @multica/views exec vitest run issues/components/issue-detail.test.tsxpnpm --filter @multica/views typecheckgit diff --check -- packages/views/issues/components/issue-detail.tsx packages/views/issues/components/issue-detail.test.tsxpnpm lint,pnpm typecheck,pnpm test, andpnpm buildChecklist
apps/web/features/landing/i18n/) and relevant docs (apps/docs/content/docs/)apps/docs/content/docs/developers/conventions.zh.mdx(terminology, mixed-rule fortask/issue/skill)AI Disclosure
AI tool used: Codex
Prompt / approach: Ported the downstream FurtherRef fix for
furtherref/multica#57onto the latest upstreammain, reviewed the patch against the current upstream issue-detail flow, checked for an existing upstream fix/open PR, and ran targeted plus full pre-push verification.Screenshots (optional)
N/A — cache recovery path covered by regression test.