Conversation
wlthomson
suggested changes
Oct 21, 2019
Contributor
wlthomson
left a comment
wlthomson
left a comment
There was a problem hiding this comment.
TESTS
- Have an ItemLine/Supplier/Customer with a really long name and look at the name in the DataTable, should look all good over two lines. SUCCESS.
CODE
LGTM. One small naming nit.
| return ( | ||
| <View style={internalViewStyle}> | ||
| <Text ellipsizeMode="tail" numberOfLines={1} style={textStyle}> | ||
| <Text ellipsizeMode="tail" numberOfLines={maxLines} style={textStyle}> |
Contributor
There was a problem hiding this comment.
Just my opinion, think its nice to use consistent props with the underlying component. E.g. numberOfLines instead of maxLines. I think unless the underlying component is being used in a very different way, it makes sense to model component "APIs" consistently with the conventions used by the built-in components?
wlthomson
approved these changes
Oct 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1405
Change summary
maxLinesprop toCell, default of 2Testing
ItemLine/Supplier/Customerwith a really long name and look at the name in theDataTable, should look all good over two linesRelated areas to think about
N/A
have updated PR for
react-native-data-table: msupply-foundation/react-native-data-table#57