make it compile in clang#1
Open
kmike wants to merge 8 commits into
Open
Conversation
std::pair is defined with int argument first, float argument second. Error message: fatal error: implicit conversion from 'double' to 'int' changes value from 5.1 to 5
Error message:
Word.cc:144:8: fatal error: 'SillyLabelExtractor::set_label_candidates' hides overloaded virtual function [-Woverloaded-virtual]
void set_label_candidates(const std::string &word_form,
^
./LabelExtractor.hh:42:16: note: hidden overloaded virtual function 'LabelExtractor::set_label_candidates' declared here: type mismatch at 3rd
parameter ('float' vs 'unsigned int')
virtual void set_label_candidates(const std::string &word_form,
^
Error: ParamTable.cc:459:26: fatal error: too few arguments to function call, expected 2, have 1
I haven't checked that it works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @mpsilfve,
I'm not a C++ expert, but here are some changes to make tests compile on OS X.
They were required to make
cd src/tagger; make testscompile.Some tests still don't compile for me, e.g.
Some tests pass (TEST_Word, TEST_io, TEST_LabelExtractor, TEST_Sentence, TEST_ParamTable, TEST_Data).
Some segfault: