Open
Conversation
As far as I can tell, the ELEMENT_TYPE symbol isn't being used by this library. It conflicts with a symbol defined in the Windows SDK: libaudiofile\alac\ALACBitUtilities.h(68): error C2371: 'ELEMENT_TYPE': redefinition; different basic types (compiling source file audiofile\libaudiofile\alac\ALACDecoder.cpp) C:\Program Files (x86)\Windows Kits\8.1\Include\um\winioctl.h(3944): note: see declaration of 'ELEMENT_TYPE' (compiling source file libaudiofile\alac\ALACDecoder.cpp)
This header isn't available on Windows.
The UUID symbol conflicts with a structure of the same name in the Windows SDK.
This fixes a compiler error, since std::min() is used in this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry about the renaming of
UUIDtoaf_UUID, but unfortunatelyUUIDis just one of those symbols that is all over the Windows SDK. Renaming it is probably the easiest solution here.