Skip to content

Adding use case handling for consecutive zero p values in change detection#9257

Merged
gmierz merged 1 commit intomozilla:masterfrom
MohamedBilelBesbes:CPDMethods
Mar 3, 2026
Merged

Adding use case handling for consecutive zero p values in change detection#9257
gmierz merged 1 commit intomozilla:masterfrom
MohamedBilelBesbes:CPDMethods

Conversation

@MohamedBilelBesbes
Copy link
Copy Markdown
Contributor

@MohamedBilelBesbes MohamedBilelBesbes commented Feb 25, 2026

This PR includes:

  • Use case handling for cases where p value = 0 for consecutive revisions. This use case happens when there is one change that causes the p-values of the adjacent revisions to it to be 0 so they cannot be compared to each other to determine which one corresponds to the culprit.
  • Terminology fixing (replacing magnitude_threshold by alert_threshold)

@MohamedBilelBesbes MohamedBilelBesbes force-pushed the CPDMethods branch 2 times, most recently from eb03454 to 223505f Compare February 26, 2026 14:13
@MohamedBilelBesbes MohamedBilelBesbes changed the title Adding methods implementation and p-value=0 use case handling Adding use case handling for consecutive zero p values in change detection Feb 26, 2026
Comment thread treeherder/perf/methods/BaseDetector.py Outdated
Comment thread treeherder/perf/methods/BaseDetector.py Outdated
Copy link
Copy Markdown
Collaborator

@gmierz gmierz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ thanks for the fixes!

@gmierz gmierz merged commit 793c69c into mozilla:master Mar 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants