Skip to content

Fix GCS initialization#2637

Merged
sylvestre merged 1 commit intomozilla:mainfrom
msuozzo:push-kovytyyquntz
Mar 16, 2026
Merged

Fix GCS initialization#2637
sylvestre merged 1 commit intomozilla:mainfrom
msuozzo:push-kovytyyquntz

Conversation

@msuozzo
Copy link
Contributor

@msuozzo msuozzo commented Mar 10, 2026

GCS usage currently fails as the initializtion path happens outside of a
Tokio runtime context.

GCS usage currently fails as the initializtion path happens outside of a
Tokio runtime context.
@msuozzo
Copy link
Contributor Author

msuozzo commented Mar 10, 2026

I have a separate implementation which actually colors the callers as async but it's necessarily a lot bigger a change so I figured I'd start here.

@msuozzo msuozzo changed the title Fix sync GCS initialization Fix GCS initialization Mar 11, 2026
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.38%. Comparing base (2b65ac8) to head (0f2d138).

Files with missing lines Patch % Lines
src/cache/gcs.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2637      +/-   ##
==========================================
+ Coverage   73.37%   73.38%   +0.01%     
==========================================
  Files          68       68              
  Lines       37337    37338       +1     
==========================================
+ Hits        27395    27400       +5     
+ Misses       9942     9938       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sylvestre sylvestre merged commit 7b751fc into mozilla:main Mar 16, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants