Skip to content

Fix the group bbox when the numbers are too big#20940

Open
calixteman wants to merge 1 commit intomozilla:masterfrom
calixteman:issue20872
Open

Fix the group bbox when the numbers are too big#20940
calixteman wants to merge 1 commit intomozilla:masterfrom
calixteman:issue20872

Conversation

@calixteman
Copy link
Contributor

It fixes #20872.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/8e4a47093bda5df/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6adaec6fc0b254c/output.txt

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2026

Codecov Report

❌ Patch coverage is 9.09091% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.58%. Comparing base (918a319) to head (5992d0f).

Files with missing lines Patch % Lines
src/display/canvas.js 0.00% 27 Missing ⚠️
src/core/evaluator.js 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20940      +/-   ##
==========================================
- Coverage   62.58%   62.58%   -0.01%     
==========================================
  Files         174      174              
  Lines      121930   121939       +9     
==========================================
+ Hits        76306    76311       +5     
- Misses      45624    45628       +4     
Flag Coverage Δ
fonttest 7.66% <ø> (ø)
unittestcli 62.55% <9.09%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests. Thank you!

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/6adaec6fc0b254c/output.txt

Total script time: 72.41 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 20

Image differences available at: http://54.193.163.58:8877/6adaec6fc0b254c/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/8e4a47093bda5df/output.txt

Total script time: 45.77 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 20

Image differences available at: http://54.241.84.105:8877/8e4a47093bda5df/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio browsertest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/dc6557b7b89657a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/68004c1e54d4804/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/dc6557b7b89657a/output.txt

Total script time: 18.40 mins

  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/68004c1e54d4804/output.txt

Total script time: 25.34 mins

  • Regression tests: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Form XObject with extreme BBox values causes blank white page in Chromium-based browsers

5 participants