Skip to content

Fix charSpacing in vertical mode#20933

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:issue20930
Mar 21, 2026
Merged

Fix charSpacing in vertical mode#20933
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:issue20930

Conversation

@calixteman
Copy link
Contributor

It fixes #20930.
And use the defaultVMetrics (coming from DW2 property) in the font.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f746df56907eac0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fefcad5aac012ca/output.txt

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.67%. Comparing base (ab228da) to head (eaa5eca).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/core/evaluator.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20933      +/-   ##
==========================================
- Coverage   62.72%   62.67%   -0.05%     
==========================================
  Files         173      173              
  Lines      121500   121504       +4     
==========================================
- Hits        76205    76151      -54     
- Misses      45295    45353      +58     
Flag Coverage Δ
fonttest 7.66% <0.00%> (ø)
unittestcli 62.64% <83.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/fefcad5aac012ca/output.txt

Total script time: 46.00 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 4

Image differences available at: http://54.241.84.105:8877/fefcad5aac012ca/reftest-analyzer.html#web=eq.log

It fixes mozilla#20930.
And use the defaultVMetrics (coming from DW2 property) in the font.
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/183b9ab1e049534/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/d52d4303d9a6778/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/f746df56907eac0/output.txt

Total script time: 73.01 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 4

Image differences available at: http://54.193.163.58:8877/f746df56907eac0/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/183b9ab1e049534/output.txt

Total script time: 45.90 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/d52d4303d9a6778/output.txt

Total script time: 72.66 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/74d6fbd4feb63cc/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/74d6fbd4feb63cc/output.txt

Total script time: 1.18 mins

Published

@timvandermeij timvandermeij merged commit a90215d into mozilla:master Mar 21, 2026
15 checks passed
@timvandermeij
Copy link
Contributor

Thank you for fixing this!

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2111b7d31000d30/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b1796086afc1c0b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/2111b7d31000d30/output.txt

Total script time: 18.69 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/b1796086afc1c0b/output.txt

Total script time: 25.01 mins

  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect charSpacing handling causes drifting bounding boxes in getTextContent.

4 participants