Skip to content

Avoid getting null value in RefSet when cloning#20924

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:fix_null_ref
Mar 20, 2026
Merged

Avoid getting null value in RefSet when cloning#20924
calixteman merged 1 commit intomozilla:masterfrom
calixteman:fix_null_ref

Conversation

@calixteman
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.65%. Comparing base (ff1af5a) to head (c17801b).

Files with missing lines Patch % Lines
src/core/editor/pdf_editor.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20924   +/-   ##
=======================================
  Coverage   62.65%   62.65%           
=======================================
  Files         173      173           
  Lines      121383   121385    +2     
=======================================
+ Hits        76049    76051    +2     
  Misses      45334    45334           
Flag Coverage Δ
fonttest 7.66% <ø> (ø)
unittestcli 62.62% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@calixteman
Copy link
Contributor Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/13d5100b019b1fa/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a863b73a6e6c962/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/13d5100b019b1fa/output.txt

Total script time: 2.76 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/a863b73a6e6c962/output.txt

Total script time: 6.61 mins

  • Unit Tests: Passed

@calixteman calixteman merged commit 504505b into mozilla:master Mar 20, 2026
15 checks passed
@calixteman calixteman added the To Review For PRs to review after they've been merged (for example when reviewers are off). label Mar 20, 2026
@calixteman calixteman deleted the fix_null_ref branch March 20, 2026 15:31
@timvandermeij timvandermeij removed their request for review March 20, 2026 18:57
@timvandermeij timvandermeij removed the To Review For PRs to review after they've been merged (for example when reviewers are off). label Mar 20, 2026
@timvandermeij
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants