Skip to content

Fix the intermittent issue in reorganize_pages spec#20902

Open
calixteman wants to merge 1 commit intomozilla:masterfrom
calixteman:fix_intermittent_reorganize
Open

Fix the intermittent issue in reorganize_pages spec#20902
calixteman wants to merge 1 commit intomozilla:masterfrom
calixteman:fix_intermittent_reorganize

Conversation

@calixteman
Copy link
Contributor

The intermittent problem is very likely because the thumbnail we want to dnd is not or partially visible.
So this patch helps to reduce enough the size of the thumbnails before starting to dnd them.

The intermittent problem is very likely because the thumbnail we want to dnd
is not or partially visible.
So this patch helps to reduce enough the size of the thumbnails before starting to dnd them.
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.56%. Comparing base (1f94023) to head (7ce2114).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20902      +/-   ##
==========================================
- Coverage   62.57%   62.56%   -0.02%     
==========================================
  Files         173      173              
  Lines      121258   121258              
==========================================
- Hits        75878    75863      -15     
- Misses      45380    45395      +15     
Flag Coverage Δ
fonttest ?
unittestcli 62.56% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij
Copy link
Contributor

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8243f98b38bf11c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3b2283afaee36f9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/8243f98b38bf11c/output.txt

Total script time: 25.41 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/3b2283afaee36f9/output.txt

Total script time: 44.72 mins

  • Integration Tests: FAILED

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but while Linux is happy now it looks like Windows still has some issues with the drag-and-drop logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Fix permafail in the "should reorder thumbnails after dropping two adjacent pages" integration test

4 participants