Fix the intermittent issue in reorganize_pages spec#20902
Fix the intermittent issue in reorganize_pages spec#20902calixteman wants to merge 1 commit intomozilla:masterfrom
Conversation
The intermittent problem is very likely because the thumbnail we want to dnd is not or partially visible. So this patch helps to reduce enough the size of the thumbnails before starting to dnd them.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20902 +/- ##
==========================================
- Coverage 62.57% 62.56% -0.02%
==========================================
Files 173 173
Lines 121258 121258
==========================================
- Hits 75878 75863 -15
- Misses 45380 45395 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8243f98b38bf11c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3b2283afaee36f9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/8243f98b38bf11c/output.txt Total script time: 25.41 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/3b2283afaee36f9/output.txt Total script time: 44.72 mins
|
timvandermeij
left a comment
There was a problem hiding this comment.
The change looks good, but while Linux is happy now it looks like Windows still has some issues with the drag-and-drop logic.
The intermittent problem is very likely because the thumbnail we want to dnd is not or partially visible.
So this patch helps to reduce enough the size of the thumbnails before starting to dnd them.